Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(formatting): Add trailing commas #3084

Merged
merged 4 commits into from Mar 5, 2024

Conversation

BalduinLandolt
Copy link
Collaborator

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@BalduinLandolt BalduinLandolt self-assigned this Mar 5, 2024
@BalduinLandolt BalduinLandolt marked this pull request as ready for review March 5, 2024 08:20
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.85%. Comparing base (eac5751) to head (dea9901).
Report is 104 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3084      +/-   ##
==========================================
+ Coverage   11.74%   12.85%   +1.11%     
==========================================
  Files         246      261      +15     
  Lines       22907    22396     -511     
==========================================
+ Hits         2690     2880     +190     
+ Misses      20217    19516     -701     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@seakayone
Copy link
Collaborator

praise: This is something I wish we had for a long time already

FYI: I have added this to dsp-ingest: dasch-swiss/dsp-ingest#180

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of formatting taks is good to announce and start when nothing is in progress due to conflicts hell, hopefully it will go smooth.

@BalduinLandolt
Copy link
Collaborator Author

This kind of formatting taks is good to announce and start when nothing is in progress due to conflicts hell, hopefully it will go smooth.

You're right. It's something I remembered spontaneously, but I should have announced it. However, it's an easy one to resolve any conflicts: You can just accept any other change, and then do fmt

@BalduinLandolt BalduinLandolt enabled auto-merge (squash) March 5, 2024 10:55
@BalduinLandolt BalduinLandolt merged commit b0b5e25 into main Mar 5, 2024
12 of 13 checks passed
@BalduinLandolt BalduinLandolt deleted the chore/add-trailing-commas branch March 5, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants