New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(formatting): Add trailing commas #3084
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3084 +/- ##
==========================================
+ Coverage 11.74% 12.85% +1.11%
==========================================
Files 246 261 +15
Lines 22907 22396 -511
==========================================
+ Hits 2690 2880 +190
+ Misses 20217 19516 -701 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
praise: This is something I wish we had for a long time already FYI: I have added this to dsp-ingest: dasch-swiss/dsp-ingest#180 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kind of formatting taks is good to announce and start when nothing is in progress due to conflicts hell, hopefully it will go smooth.
You're right. It's something I remembered spontaneously, but I should have announced it. However, it's an easy one to resolve any conflicts: You can just accept any other change, and then do |
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?