Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused code from standoff responder (DEV-3264) #3085

Conversation

BalduinLandolt
Copy link
Collaborator

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Mar 5, 2024

@BalduinLandolt BalduinLandolt changed the title remove standoff stuff chore: Remove unused code from standoff responder (DEV-3264) Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.92%. Comparing base (eac5751) to head (c8a979a).
Report is 111 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3085      +/-   ##
==========================================
+ Coverage   11.74%   12.92%   +1.18%     
==========================================
  Files         246      260      +14     
  Lines       22907    22337     -570     
==========================================
+ Hits         2690     2887     +197     
+ Misses      20217    19450     -767     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt marked this pull request as ready for review March 5, 2024 09:43
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's a bit tougher to sift through, but I managed it!

@BalduinLandolt BalduinLandolt enabled auto-merge (squash) March 5, 2024 11:35
@BalduinLandolt BalduinLandolt self-assigned this Mar 6, 2024
@BalduinLandolt BalduinLandolt merged commit 56815a3 into main Mar 6, 2024
13 checks passed
@BalduinLandolt BalduinLandolt deleted the feature/dev-3264-remove-unnecessary-standoff-responder-methods branch March 6, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants