Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Sipi to 3.9.0 #3097

Merged
merged 3 commits into from Mar 7, 2024

Conversation

subotic
Copy link
Collaborator

@subotic subotic commented Mar 6, 2024

Pull Request Checklist

Task Description/Number

related to DEV-3269

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Mar 6, 2024

@subotic subotic self-assigned this Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.92%. Comparing base (eac5751) to head (a33be08).
Report is 115 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3097      +/-   ##
==========================================
+ Coverage   11.74%   12.92%   +1.18%     
==========================================
  Files         246      260      +14     
  Lines       22907    22339     -568     
==========================================
+ Hits         2690     2887     +197     
+ Misses      20217    19452     -765     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone
Copy link
Collaborator

In order to integrate this into dsp-ingest we have to do the release of dsp-api first and then update the sipi version to the latest dsp-api release.

@mpro7 can you take care of this during the release please?

@mpro7 mpro7 merged commit 4b6e638 into main Mar 7, 2024
13 checks passed
@mpro7 mpro7 deleted the feature/dev-3269-support-transparent-still-images branch March 7, 2024 13:07
@mpro7
Copy link
Collaborator

mpro7 commented Mar 7, 2024

In order to integrate this into dsp-ingest we have to do the release of dsp-api first and then update the sipi version to the latest dsp-api release.

@mpro7 can you take care of this during the release please?

Will do, thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants