Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(knora-admin): Remove unused Institution class and its properties (DEV-3365) #3109

Merged
merged 11 commits into from Mar 14, 2024

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Mar 11, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone changed the title refactor: Remove unused belongs to institution property refactor: Remove unused Institution class and its properties Mar 11, 2024
@seakayone seakayone changed the title refactor: Remove unused Institution class and its properties refactor(knora-admin): Remove unused Institution class and its properties Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 88.77%. Comparing base (eac5751) to head (998e921).
Report is 126 commits behind head on main.

Files Patch % Lines
...plestore/upgrade/plugins/UpgradePluginPR3110.scala 0.00% 13 Missing ⚠️
...e/upgrade/plugins/AbstractSparqlUpdatePlugin.scala 0.00% 7 Missing ⚠️
...ore/triplestore/upgrade/RepositoryUpdatePlan.scala 0.00% 1 Missing ⚠️
.../store/triplestore/upgrade/RepositoryUpdater.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3109       +/-   ##
===========================================
+ Coverage   11.74%   88.77%   +77.03%     
===========================================
  Files         246      262       +16     
  Lines       22907    22396      -511     
===========================================
+ Hits         2690    19883    +17193     
+ Misses      20217     2513    -17704     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone changed the title refactor(knora-admin): Remove unused Institution class and its properties refactor(knora-admin): Remove unused Institution class and its properties (DEV-3365) Mar 11, 2024
Copy link

linear bot commented Mar 11, 2024

@seakayone seakayone force-pushed the refactor/remove-unused-belongs-to-institution-property branch from 77de981 to 66105eb Compare March 12, 2024 09:59
@seakayone seakayone marked this pull request as ready for review March 13, 2024 11:30
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Would you mind adding this to the migrations RFC? I think that's already a bit more ergonomical than it used to be - and it should be fast since it works only on one graph.

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@seakayone seakayone merged commit 7e3664d into main Mar 14, 2024
13 checks passed
@seakayone seakayone deleted the refactor/remove-unused-belongs-to-institution-property branch March 14, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants