Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate GET /version and /health to tapir (DEV-3286, DEV-3287) #3110

Merged

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Mar 11, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 12.90%. Comparing base (eac5751) to head (4f5aa3d).
Report is 124 commits behind head on main.

Files Patch % Lines
...slice/infrastructure/api/ManagementEndpoints.scala 0.00% 42 Missing ⚠️
...ain/scala/org/knora/webapi/routing/ApiRoutes.scala 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3110      +/-   ##
==========================================
+ Coverage   11.74%   12.90%   +1.16%     
==========================================
  Files         246      260      +14     
  Lines       22907    22382     -525     
==========================================
+ Hits         2690     2889     +199     
+ Misses      20217    19493     -724     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone changed the title refactor: Migrate GET /version to tapir refactor: Migrate GET /version and /health to tapir Mar 12, 2024
@seakayone seakayone changed the title refactor: Migrate GET /version and /health to tapir refactor: Migrate GET /version and /health to tapir (DEV-3286, DEV-3287) Mar 12, 2024
Copy link

linear bot commented Mar 12, 2024

@seakayone seakayone marked this pull request as ready for review March 12, 2024 09:57
@seakayone seakayone self-assigned this Mar 12, 2024
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor suggestion below. Feel free to either skip it or apply it:

docs/03-endpoints/api-util/version.md Outdated Show resolved Hide resolved
@seakayone seakayone enabled auto-merge (squash) March 12, 2024 13:01
@seakayone seakayone merged commit c7d69aa into main Mar 12, 2024
13 checks passed
@seakayone seakayone deleted the refactor/migrate-health-and-version-endpoints-to-tapir branch March 12, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants