Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: In Sipi use size fallback only when api failed to return a setting (DEV-3409) #3112

Merged

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Mar 12, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone changed the title fix: In Sipi use size fallback only when api failed to return a setting fix: In Sipi use size fallback only when api failed to return a setting (DEV-3409) Mar 12, 2024
Copy link

linear bot commented Mar 12, 2024

@seakayone seakayone requested a review from irmastnt March 12, 2024 12:03
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.90%. Comparing base (eac5751) to head (1aef8ea).
Report is 125 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3112      +/-   ##
==========================================
+ Coverage   11.74%   12.90%   +1.16%     
==========================================
  Files         246      260      +14     
  Lines       22907    22382     -525     
==========================================
+ Hits         2690     2889     +199     
+ Misses      20217    19493     -724     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone enabled auto-merge (squash) March 12, 2024 13:01
@seakayone seakayone merged commit 172041a into main Mar 12, 2024
13 checks passed
@seakayone seakayone deleted the fix/only-use-fallback-for-size-if-api-does-not-return-anything branch March 12, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants