Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove invalid watermark triples (DEV-3418) #3116

Merged
merged 13 commits into from Mar 14, 2024

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Mar 13, 2024

  • fix: Add database migration which removes invalid triples from the database

Depends on https://github.com/dasch-swiss/dsp-api/tree/refactor/remove-unused-belongs-to-institution-property being merged first.

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Mar 13, 2024

@seakayone seakayone force-pushed the fix/remove-invalid-triples-watermarking branch from a526750 to d7be347 Compare March 13, 2024 16:01
@seakayone seakayone changed the title fis: Remove invalid watermark triples (DEV-3418) fix: Remove invalid watermark triples (DEV-3418) Mar 13, 2024
@seakayone seakayone changed the base branch from main to refactor/remove-unused-belongs-to-institution-property March 13, 2024 16:02
@seakayone seakayone force-pushed the fix/remove-invalid-triples-watermarking branch from d7be347 to 7d4c818 Compare March 13, 2024 16:03
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 12.86%. Comparing base (7e3664d) to head (7f85701).

Files Patch % Lines
...plestore/upgrade/plugins/UpgradePluginPR3111.scala 0.00% 7 Missing ⚠️
...bapi/src/main/scala/org/knora/webapi/package.scala 0.00% 1 Missing ⚠️
...ore/triplestore/upgrade/RepositoryUpdatePlan.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3116       +/-   ##
===========================================
- Coverage   88.77%   12.86%   -75.92%     
===========================================
  Files         262      263        +1     
  Lines       22396    22404        +8     
===========================================
- Hits        19883     2882    -17001     
- Misses       2513    19522    +17009     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone marked this pull request as ready for review March 13, 2024 16:28
Base automatically changed from refactor/remove-unused-belongs-to-institution-property to main March 14, 2024 07:54
@seakayone seakayone force-pushed the fix/remove-invalid-triples-watermarking branch from 7d4c818 to a526750 Compare March 14, 2024 07:55
@seakayone seakayone closed this Mar 14, 2024
@seakayone seakayone force-pushed the fix/remove-invalid-triples-watermarking branch from a526750 to 7e3664d Compare March 14, 2024 07:56
@seakayone seakayone reopened this Mar 14, 2024
@seakayone seakayone enabled auto-merge (squash) March 14, 2024 10:26
@seakayone seakayone merged commit e563ab9 into main Mar 14, 2024
15 checks passed
@seakayone seakayone deleted the fix/remove-invalid-triples-watermarking branch March 14, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants