Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable broken upgrade plugins #3117

Merged
merged 1 commit into from Mar 14, 2024

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Mar 14, 2024

When using more than the built-in graphs the RepositoryUpdater fails to append data in the downloaded files.
Until this is resolved we need to disable the plugins and remain on knora-base version 28.

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

When using more than the built-in graphs the RepositoryUpdater fails to append data in the downloaded files.
Until this is resolved we need to disable the plugins and remain on knora-base version 28.
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (eac5751) to head (1862fff).
Report is 128 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3117       +/-   ##
===========================================
+ Coverage   11.74%   88.75%   +77.01%     
===========================================
  Files         246      263       +17     
  Lines       22907    22402      -505     
===========================================
+ Hits         2690    19883    +17193     
+ Misses      20217     2519    -17698     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone merged commit 6714898 into main Mar 14, 2024
14 checks passed
@seakayone seakayone deleted the fix/revert-adding-upgrade-plugins-until-fixed branch March 14, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants