Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add additional project export route that awaits the process #3136

Merged
merged 8 commits into from Mar 20, 2024

Conversation

BalduinLandolt
Copy link
Collaborator

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@BalduinLandolt BalduinLandolt self-assigned this Mar 20, 2024
@BalduinLandolt BalduinLandolt marked this pull request as ready for review March 20, 2024 15:31
Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Two minor suggestions below.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 13.14%. Comparing base (eac5751) to head (5b10f78).
Report is 144 commits behind head on main.

Files Patch % Lines
...ce/admin/domain/service/ProjectExportService.scala 0.00% 4 Missing ⚠️
...api/slice/admin/api/ProjectsEndpointsHandler.scala 0.00% 3 Missing ⚠️
...ice/admin/api/service/ProjectsADMRestService.scala 0.00% 3 Missing ⚠️
...ora/webapi/slice/admin/api/ProjectsEndpoints.scala 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3136      +/-   ##
==========================================
+ Coverage   11.74%   13.14%   +1.40%     
==========================================
  Files         246      264      +18     
  Lines       22907    22404     -503     
==========================================
+ Hits         2690     2945     +255     
+ Misses      20217    19459     -758     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt enabled auto-merge (squash) March 20, 2024 15:50
@BalduinLandolt BalduinLandolt merged commit 70e0172 into main Mar 20, 2024
13 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/implement-awaiting-export-route branch March 20, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants