New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: GroupsResponderADM cleanup (DEV-3292) #3139
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3139 +/- ##
===========================================
- Coverage 88.79% 13.13% -75.66%
===========================================
Files 265 266 +1
Lines 22260 22239 -21
===========================================
- Hits 19765 2921 -16844
- Misses 2495 19318 +16823 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly like it, but please remove all the throw
s
webapi/src/main/scala/org/knora/webapi/slice/admin/AdminModule.scala
Outdated
Show resolved
Hide resolved
AppConfig & AssetPermissionsResponder & AuthorizationRestService & BaseEndpoints & CacheService & GroupsResponderADM & HandlerMapper & KnoraProjectService & KnoraResponseRenderer & KnoraUserService & KnoraUserToUserConverter & ListsResponder & MaintenanceService & OntologyCache & PasswordService & PermissionsResponderADM & ProjectExportService & ProjectImportService & ProjectService & TapirToPekkoInterpreter & TriplestoreService & UserService & UsersResponder | ||
AppConfig & AssetPermissionsResponder & AuthorizationRestService & BaseEndpoints & CacheService & | ||
GroupsResponderADM & GroupService & HandlerMapper & KnoraProjectService & KnoraResponseRenderer & | ||
KnoraUserService & KnoraUserToUserConverter & ListsResponder & MaintenanceService & OntologyCache & | ||
PasswordService & PermissionsResponderADM & ProjectExportService & ProjectImportService & ProjectService & | ||
TapirToPekkoInterpreter & TriplestoreService & UserService & UsersResponder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See replay above :)
Pull Request Checklist
Task Description/Number
Removed trait,
groupsGetADM
and partiallygroupGetADM
methods, including swapping the responder with service / rest service in tests as well as affected packages. I struggle to makeGroupsResponderADM
removal more organized but this is the first part of it (also to keep PR relatively small).Issue Number: DEV-3292
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?