Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: GroupsResponderADM cleanup (DEV-3292) #3139

Merged
merged 24 commits into from Apr 4, 2024
Merged

chore: GroupsResponderADM cleanup (DEV-3292) #3139

merged 24 commits into from Apr 4, 2024

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Mar 21, 2024

Pull Request Checklist

Task Description/Number

Removed trait,groupsGetADM and partially groupGetADM methods, including swapping the responder with service / rest service in tests as well as affected packages. I struggle to make GroupsResponderADM removal more organized but this is the first part of it (also to keep PR relatively small).

Issue Number: DEV-3292

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Mar 21, 2024

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 5.55556% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 13.13%. Comparing base (62260e4) to head (8f45c7a).
Report is 13 commits behind head on main.

Files Patch % Lines
...bapi/slice/admin/domain/service/GroupService.scala 0.00% 21 Missing ⚠️
...api/responders/admin/PermissionsResponderADM.scala 0.00% 18 Missing ⚠️
...api/slice/admin/api/service/UsersRestService.scala 0.00% 4 Missing ⚠️
...pi/slice/admin/api/service/GroupsRestService.scala 0.00% 3 Missing ⚠️
...a/webapi/slice/admin/domain/model/KnoraGroup.scala 60.00% 2 Missing ⚠️
...a/webapi/responders/admin/GroupsResponderADM.scala 0.00% 1 Missing ⚠️
...slice/admin/domain/service/KnoraGroupService.scala 0.00% 1 Missing ⚠️
...dmin/domain/service/KnoraUserToUserConverter.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3139       +/-   ##
===========================================
- Coverage   88.79%   13.13%   -75.66%     
===========================================
  Files         265      266        +1     
  Lines       22260    22239       -21     
===========================================
- Hits        19765     2921    -16844     
- Misses       2495    19318    +16823     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpro7 mpro7 self-assigned this Apr 2, 2024
@mpro7 mpro7 changed the title Remove GroupsResponderADM chore: Remove GroupsResponderADM Apr 2, 2024
@mpro7 mpro7 changed the title chore: Remove GroupsResponderADM chore: GroupsResponderADM cleanup (DEV-3292) Apr 3, 2024
@mpro7 mpro7 marked this pull request as ready for review April 3, 2024 15:02
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly like it, but please remove all the throws

Comment on lines -40 to +45
AppConfig & AssetPermissionsResponder & AuthorizationRestService & BaseEndpoints & CacheService & GroupsResponderADM & HandlerMapper & KnoraProjectService & KnoraResponseRenderer & KnoraUserService & KnoraUserToUserConverter & ListsResponder & MaintenanceService & OntologyCache & PasswordService & PermissionsResponderADM & ProjectExportService & ProjectImportService & ProjectService & TapirToPekkoInterpreter & TriplestoreService & UserService & UsersResponder
AppConfig & AssetPermissionsResponder & AuthorizationRestService & BaseEndpoints & CacheService &
GroupsResponderADM & GroupService & HandlerMapper & KnoraProjectService & KnoraResponseRenderer &
KnoraUserService & KnoraUserToUserConverter & ListsResponder & MaintenanceService & OntologyCache &
PasswordService & PermissionsResponderADM & ProjectExportService & ProjectImportService & ProjectService &
TapirToPekkoInterpreter & TriplestoreService & UserService & UsersResponder
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See replay above :)

@mpro7 mpro7 requested a review from seakayone April 4, 2024 11:53
@mpro7 mpro7 requested a review from seakayone April 4, 2024 12:55
@seakayone seakayone self-requested a review April 4, 2024 13:26
@mpro7 mpro7 merged commit 772b160 into main Apr 4, 2024
13 checks passed
@mpro7 mpro7 deleted the dev-3292-2 branch April 4, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants