Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error message does not interpolate invalid property IRI #3144

Merged
merged 1 commit into from Mar 25, 2024

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented Mar 25, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@BalduinLandolt BalduinLandolt self-assigned this Mar 25, 2024
@BalduinLandolt BalduinLandolt marked this pull request as ready for review March 25, 2024 11:09
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (b1d5743) to head (75a98fd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3144       +/-   ##
===========================================
+ Coverage   13.18%   88.81%   +75.62%     
===========================================
  Files         266      266               
  Lines       22337    22308       -29     
===========================================
+ Hits         2946    19813    +16867     
+ Misses      19391     2495    -16896     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt removed the request for review from siers March 25, 2024 13:16
@BalduinLandolt BalduinLandolt changed the title fix: Error message does interpolate wrong property IRI fix: Error message does not interpolate invalid property IRI Mar 25, 2024
@BalduinLandolt BalduinLandolt enabled auto-merge (squash) March 25, 2024 13:27
@BalduinLandolt BalduinLandolt merged commit b87f6c1 into main Mar 25, 2024
15 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/fix-wrong-error-message branch March 25, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants