Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Deprecated as a category in our release notes #3160

Merged
merged 6 commits into from Apr 3, 2024

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented Apr 2, 2024

Pull Request Checklist

Task Description/Number

We can discuss this in due time, @seakayone has some ideas on that, which will eventually turn into an RFC.

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@BalduinLandolt BalduinLandolt self-assigned this Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.26%. Comparing base (62260e4) to head (4b168f5).
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3160       +/-   ##
===========================================
- Coverage   88.79%   13.26%   -75.53%     
===========================================
  Files         265      265               
  Lines       22260    22252        -8     
===========================================
- Hits        19765     2952    -16813     
- Misses       2495    19300    +16805     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt marked this pull request as ready for review April 2, 2024 14:17
Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@BalduinLandolt BalduinLandolt enabled auto-merge (squash) April 3, 2024 11:38
@BalduinLandolt BalduinLandolt merged commit 937480c into main Apr 3, 2024
13 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/add-deprecation-to-release-please branch April 3, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants