Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated: Mark isSequenceOf as deprecated and document Segment as alternative (DEV-3455) #3161

Merged
merged 12 commits into from Apr 4, 2024

Conversation

BalduinLandolt
Copy link
Collaborator

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

Copy link

linear bot commented Apr 2, 2024

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.49%. Comparing base (62260e4) to head (8e81059).
Report is 15 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3161       +/-   ##
===========================================
- Coverage   88.79%   13.49%   -75.30%     
===========================================
  Files         265      269        +4     
  Lines       22260    22334       +74     
===========================================
- Hits        19765     3014    -16751     
- Misses       2495    19320    +16825     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt marked this pull request as ready for review April 2, 2024 14:44
@BalduinLandolt BalduinLandolt marked this pull request as draft April 3, 2024 10:47
@BalduinLandolt BalduinLandolt marked this pull request as ready for review April 3, 2024 11:25
@BalduinLandolt BalduinLandolt changed the title docs: Add documentation on Segment and a migration guide for v31 (DEV-3455) deprecated: mark isSequenceOf as deprecated and document Segment as alternative (DEV-3455) Apr 3, 2024
@BalduinLandolt BalduinLandolt changed the title deprecated: mark isSequenceOf as deprecated and document Segment as alternative (DEV-3455) deprecated: Mark isSequenceOf as deprecated and document Segment as alternative (DEV-3455) Apr 3, 2024
Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment below.

docs/10-migration-guides/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through all of it, sounds good!

BalduinLandolt and others added 2 commits April 4, 2024 16:02
Co-authored-by: Marcin Procyk <marcin.procyk@dasch.swiss>
@BalduinLandolt BalduinLandolt enabled auto-merge (squash) April 4, 2024 14:06
@BalduinLandolt BalduinLandolt merged commit e45b41a into main Apr 4, 2024
13 checks passed
@BalduinLandolt BalduinLandolt deleted the feature/dev-3455-segment-documentation-in-api branch April 4, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants