Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use shortname for project export (DEV-3430) #3169

Merged
merged 3 commits into from Apr 5, 2024

Conversation

siers
Copy link
Contributor

@siers siers commented Apr 4, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@siers siers self-assigned this Apr 4, 2024
Copy link

linear bot commented Apr 4, 2024

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 13.49%. Comparing base (e666752) to head (e72d462).

Files Patch % Lines
.../slice/admin/api/model/ProjectExportResponse.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3169       +/-   ##
===========================================
- Coverage   88.78%   13.49%   -75.30%     
===========================================
  Files         269      269               
  Lines       22334    22334               
===========================================
- Hits        19830     3014    -16816     
- Misses       2504    19320    +16816     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siers siers force-pushed the fix/fix-shortcode-DEV-3430 branch from 12819c1 to ccbc4bc Compare April 4, 2024 14:24
@siers siers force-pushed the fix/fix-shortcode-DEV-3430 branch from ccbc4bc to d0fe3b6 Compare April 4, 2024 14:25
@siers siers enabled auto-merge (squash) April 5, 2024 07:01
@siers siers merged commit f25cfa9 into main Apr 5, 2024
14 checks passed
@siers siers deleted the fix/fix-shortcode-DEV-3430 branch April 5, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants