refactor: Move creation Group from responder to services (DEV-3292) #3185
Conversation
mpro7
changed the title
webapi/src/main/scala/org/knora/webapi/slice/admin/domain/service/GroupService.scala
Outdated
Show resolved
Hide resolved
| hasSelfJoinEnabled = request.selfjoin, | ||
| ) | ||
| _ <- knoraGroupRepo.save(group) | ||
| } yield group |
There was a problem hiding this comment.
Shouldn't this belong in KnoraGroupRepo? What's the difference between KnoraGroupRepo and this file? In master this file is a really thin wrapper over it, does it really serve a purpose? I see @seakayone made it.
There was a problem hiding this comment.
The sole responsibility for repositories is to store entities and retrieve them. Maintaining constraints on certain properties of the entity which cannot be modelled by a type system, e.g. the uniqueness of a property other than the id of the entity is not the responsibility of a repository.
The admin module does not expose the repositories but only services operating on these. The methods of these services represent certain use cases and contain the business logic based on them, e.g. the creation of a group with a custom IRI.
webapi/src/main/scala/org/knora/webapi/slice/admin/domain/service/KnoraGroupService.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/admin/api/service/GroupRestService.scala
Outdated
Show resolved
Hide resolved
webapi/src/main/scala/org/knora/webapi/slice/admin/domain/service/KnoraGroupService.scala
Show resolved
Hide resolved
mpro7
changed the title
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?