Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unused dependency from KnoraGroupService #3192

Merged
merged 1 commit into from Apr 15, 2024
Merged

chore: Remove unused dependency from KnoraGroupService #3192

merged 1 commit into from Apr 15, 2024

Conversation

seakayone
Copy link
Collaborator

@seakayone seakayone commented Apr 15, 2024 •
edited

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone mentioned this pull request Apr 15, 2024
Merged
12 tasks
@seakayone seakayone enabled auto-merge (squash) April 15, 2024 13:49
@seakayone seakayone merged commit 26e62f8 into main Apr 15, 2024
12 checks passed
@seakayone seakayone deleted the chore/remove-unused-dependency-from-KnoraGroupService branch April 15, 2024 14:14
@daschbot daschbot mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siers siers siers approved these changes

@BalduinLandolt BalduinLandolt Awaiting requested review from BalduinLandolt BalduinLandolt is a code owner

@mpro7 mpro7 Awaiting requested review from mpro7 mpro7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seakayone @siers