Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: add default background color to release badge (DEV-1918) #958

Merged
merged 1 commit into from Mar 17, 2023
Merged

style: add default background color to release badge (DEV-1918) #958

merged 1 commit into from Mar 17, 2023

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Mar 17, 2023

resolves DEV-1918

@mdelez mdelez added styling Update style; no production code change chore Maintenance and build tasks labels Mar 17, 2023
@mdelez mdelez self-assigned this Mar 17, 2023
@linear
Copy link

linear bot commented Mar 17, 2023

DEV-1918 DSP-APP: Can't see release number if no environment variable

Screenshot 2023-03-17 at 14.49.29.png

There should be a default background color

@mdelez mdelez marked this pull request as ready for review March 17, 2023 14:04
LukasStoeckli
LukasStoeckli approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@LukasStoeckli LukasStoeckli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks

@mdelez mdelez merged commit 17c94d7 into main Mar 17, 2023
10 checks passed
@mdelez mdelez deleted the wip/dev-1918-release-badge-default-css branch March 17, 2023 14:07
@daschbot daschbot mentioned this pull request Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasStoeckli LukasStoeckli LukasStoeckli approved these changes

Assignees

@mdelez mdelez

Labels
chore Maintenance and build tasks styling Update style; no production code change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdelez @LukasStoeckli