feat: activate not-exists for link prop #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-1966 Activate not-exists for link
The not exists in the advanced search was commented out for the linking property case. After investigation & fixing a potential bug on the api side, this should be activated |
EricSommerhalder
approved these changes
Apr 12, 2023
| @@ -323,45 +323,45 @@ describe('SpecifyPropertyValueComponent', () => { | |||
| ).toEqual(8); | |||
| }); | |||
|
|
|||
| // it('should set the correct comparison operators for a linking property type (on top level)', () => { | |||
There was a problem hiding this comment.
Is this dead code now? I'd delete it if it's not used.
There was a problem hiding this comment.
No, I uncommented it so the test is valid for the added notexists case
| @@ -2246,54 +2246,54 @@ OFFSET 0 | |||
| ).toHaveBeenCalledTimes(1); | |||
| }); | |||
|
|
|||
| // it('Gravsearch query string with no existing LINK property values', () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-1966