Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): add comparison view (DSP-1796) #490

Merged
merged 15 commits into from Jul 26, 2021

Conversation

@kilchenmann
Copy link
Collaborator

@kilchenmann kilchenmann commented Jul 22, 2021

resolves DSP-1796

Just finished what @waychal has started.

DSP-UI PR #319 is required.

@kilchenmann kilchenmann self-assigned this Jul 22, 2021
@kilchenmann kilchenmann requested review from mdelez and Vijeinath and removed request for Vijeinath and mdelez Jul 22, 2021
@mdelez
Copy link
Contributor

@mdelez mdelez commented Jul 26, 2021

@kilchenmann should I review this?

Loading

@kilchenmann
Copy link
Collaborator Author

@kilchenmann kilchenmann commented Jul 26, 2021

@kilchenmann should I review this?

@mdelez not yet. It needs some refactoring in dsp-ui first. I'll finish the PR in ui-lib today

Loading

@kilchenmann kilchenmann marked this pull request as draft Jul 26, 2021
@kilchenmann kilchenmann marked this pull request as ready for review Jul 26, 2021
@kilchenmann kilchenmann requested review from mdelez and Vijeinath Jul 26, 2021
mdelez
mdelez approved these changes Jul 26, 2021
Copy link
Contributor

@mdelez mdelez left a comment

Works well!

Loading

@kilchenmann kilchenmann merged commit 731ea04 into main Jul 26, 2021
8 checks passed
Loading
@kilchenmann kilchenmann deleted the wip/DSP-1796-update-resource-viewer-for-comparison branch Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants