refactor: improve logging #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vijeinath
reviewed
Jun 9, 2023
| private config: DspInstrumentationConfig = inject(DspInstrumentationToken); | ||
| private session = inject(SessionService); | ||
| constructor() { | ||
| this.buildTag$.pipe(first()).subscribe((tag) => { |
There was a problem hiding this comment.
Where do you unsubscribe?
There was a problem hiding this comment.
first does it automatically after the first value is received.
Vijeinath
reviewed
Jun 9, 2023
| }); | ||
| } | ||
| // if session is valid: setActiveUser | ||
| this.session.isSessionValid().subscribe((response: boolean) => { |
There was a problem hiding this comment.
Where do you unsubscribe?
There was a problem hiding this comment.
nowhere. This is already existing code and out of scope for this round.
Vijeinath
reviewed
Jun 9, 2023
| import { z } from 'zod'; | ||
| import { inject } from '@angular/core'; | ||
| import { HttpClient } from '@angular/common/http'; | ||
| import { tap, map } from 'rxjs/operators'; |
There was a problem hiding this comment.
nowhere. will remove it.
Vijeinath
reviewed
Jun 9, 2023
| private config: DspInstrumentationConfig = inject(DspInstrumentationToken); | ||
|
|
||
| constructor() { | ||
| this.buildTag$.pipe(first()).subscribe((tag) => { |
There was a problem hiding this comment.
Where do you unsubscribe?
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-