fix(freeze): Remove/replace freezing request #1110
Conversation
DEV-1562 APP freezes completely if SIPI does not respond
It seems that there is a case when SIPI is not responding, APP hangs totally. It is related to components with an image browser (OpenSeaDragon). Improve the request handling, that it is not freezing the app while is waiting for SIPI response. Because the issue is rather hard to reproduce, an idea would be to fake this behaviour by sleeping SIPI in LUA script. |
| * return the jwt token from the session to authenticate | ||
| * @return the token | ||
| */ | ||
| public getTokenFromLocalStorage(): string { |
There was a problem hiding this comment.
This is the same method that you have below but is private. Should it be public or private?
There was a problem hiding this comment.
Damn, was due to merging. (I changed it to public in order the pdf viewer could possibly also send the token.)
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| <pdf-viewer | |||
| class="pdf-viewer" | |||
| [src]= "{ url: src.fileValue.fileUrl, withCredentials: true }" | |||
| [src]= "{ url: src.fileValue.fileUrl, withCredentials: true }" | |||
There was a problem hiding this comment.
does withCredentials have a fear of commas? :)
There was a problem hiding this comment.
I just needed some space ;-)
domsteinbach
deleted the
feature/dev-1562-app-freezes-if-sipi-does-not-respond
branch
resolves DEV-1562