Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(error-handler): move error-handler and all its dependencies into library #1126

Merged
merged 7 commits into from Jul 6, 2023
Merged

feat(error-handler): move error-handler and all its dependencies into library #1126

merged 7 commits into from Jul 6, 2023

Conversation

EricSommerhalder
Copy link
Contributor

resolves DEV-2211

@linear
Copy link

linear bot commented Jun 30, 2023

DEV-2211 Refactor ErrorHandlerService

A service should NEVER create UI elements.

@mdelez mdelez self-requested a review July 5, 2023 14:19
@subotic subotic changed the title feat(app/refactor): remove error-handler and all its dependencies from app feat(error-handler): remove error-handler and all its dependencies from app into the library Jul 6, 2023
@subotic subotic changed the title feat(error-handler): remove error-handler and all its dependencies from app into the library feat(error-handler): move error-handler and all its dependencies into library Jul 6, 2023
@subotic subotic merged commit e720bb2 into main Jul 6, 2023
12 checks passed
@subotic subotic deleted the feature/dev-2211-refactor-errorhandlerservice branch July 6, 2023 14:21
@daschbot daschbot mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelez mdelez mdelez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EricSommerhalder @mdelez @subotic