fix(image navigation): remove flickering, remove in between load images #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when another image is requested, close viewer if an image has been requested
EricSommerhalder
approved these changes
Jul 3, 2023
| // multiple pages | ||
| this._viewer.close() | ||
| if (this.imagesSub) { | ||
| this.imagesSub.unsubscribe(); |
There was a problem hiding this comment.
We really need state management for this component in the future. This is a hack at best, even though I understand its necessity.
There was a problem hiding this comment.
Indeed, the whole component needs refactoring. The hack follows the "busieness logic" ...
domsteinbach
deleted the
feature/dev-2274-wrong-in-between-images-are-shown-on-paginate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-2274 & DEV-2232