fix(visibility of menu entries): Utilise proper editing permissions for enabling/disabling editing menu items #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, rename accordingly
…t, check existence of createValueComponent
DEV-2279 Edit label button and form shouldn't be displayed (RV|KnownUser)
On the test server, project 0106 waldau-cinema, I found out that it is possible for a KnownUser to display the form Edit label in a resource viewer (resource of type StillImage in the example), even though the permissions are set to Restricted View. Hopefully, the API prevents the update action to be executed (403 error). Example: https://admin.test.dasch.swiss/project/0GvaFuSORIqfYHxv6XcZaA/ontology/waldau-cinema/ImageOfSource |
…rViewInit, check existence of createValueComponent" This reverts commit 36c0bc7.
…shouldnt-be-displayed-rvknownuser
mdelez
approved these changes
Jul 6, 2023
…shouldnt-be-displayed-rvknownuser
mdelez
deleted the
feature/dev-2279-edit-label-button-and-form-shouldnt-be-displayed-rvknownuser
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-2279