Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pendo analytics #1157

Merged
merged 1 commit into from Jul 24, 2023
Merged

Conversation

subotic
Copy link
Contributor

@subotic subotic commented Jul 21, 2023

resolves DEV-2487
resolves DEV-2241
resolves DEV-2489

@subotic subotic changed the title chore: add pendo chore: add pendo analytics Jul 21, 2023
@subotic subotic requested a review from mdelez July 21, 2023 18:21
@@ -54,30 +59,36 @@ export class DatadogRumService {
});

// if session is valid: setActiveUser
// FIXME: so that updates to the session state are reflected in the specified user
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a fixme for this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, for future PRs. I've created issues on Linear.

private environment: string = this.config.environment;

constructor() {
// FIXME: so that updates to the session state are reflected in specified user
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as previous comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, for future PRs. I've created issues on Linear.

@subotic subotic merged commit 15f7a33 into main Jul 24, 2023
12 checks passed
@subotic subotic deleted the feature/dev-2487-add-pendo-to-dsp-app branch July 24, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants