Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pdf viewer): menubar is broken #1160

Merged
merged 8 commits into from Jul 25, 2023

Conversation

domsteinbach
Copy link
Contributor

resolves DEV-1946

@linear
Copy link

linear bot commented Jul 24, 2023

@domsteinbach domsteinbach marked this pull request as ready for review July 24, 2023 12:57
@@ -88,6 +85,10 @@ export class DocumentComponent implements OnInit, AfterViewInit {
}

ngAfterViewInit() {
if (this.fileType === 'pdf') {
this.elem = document.getElementsByClassName('pdf-viewer')[0];
console.log(this.elem);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... :-)

@domsteinbach domsteinbach merged commit 22e99e5 into main Jul 25, 2023
12 checks passed
@domsteinbach domsteinbach deleted the feature/dev-1946-menubar-pdf-viewer-is-broken branch July 25, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants