chore: move date-picker out into a library #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-2502 Move date-picker out into library
We need it in the advanced search so we will need to move it from the app into a library |
Vijeinath
reviewed
Aug 3, 2023
| @@ -1,12 +1,10 @@ | |||
| import { Component, Inject, Input, OnDestroy, OnInit } from '@angular/core'; | |||
| import { | |||
| UntypedFormBuilder, | |||
| import {UntypedFormBuilder, | |||
There was a problem hiding this comment.
What is here the code convention for multiple imports?
There was a problem hiding this comment.
Basically whatever the formatter chooses when you right click > format document
Vijeinath
reviewed
Aug 3, 2023
Comment on lines
+684
to
+701
| if (calendar === 'GREGORIAN') { | ||
| const calDate = new GregorianCalendarDate( | ||
| new CalendarPeriod(date, date) | ||
| ); | ||
| return calDate.daysInMonth(date); | ||
| } else if (calendar === 'JULIAN') { | ||
| const calDate = new JulianCalendarDate( | ||
| new CalendarPeriod(date, date) | ||
| ); | ||
| return calDate.daysInMonth(date); | ||
| } else if (calendar === 'ISLAMIC') { | ||
| const calDate = new IslamicCalendarDate( | ||
| new CalendarPeriod(date, date) | ||
| ); | ||
| return calDate.daysInMonth(date); | ||
| } else { | ||
| throw Error('Unknown calendar ' + calendar); | ||
| } |
There was a problem hiding this comment.
Not mandatory but in case there are more than two if/ else if lines you can use switch case
There was a problem hiding this comment.
I agree but I didn't want to change too much of the code. I'd rather refactor it in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-2502