Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup routes and unused components #1239

Merged

Conversation

domsteinbach
Copy link
Contributor

resolves DEV-2835

@linear
Copy link

linear bot commented Oct 24, 2023

DEV-2835 Cleanup routes and unused components

Quite a lot of routes are never routed within the app. Quite a lot of components are unused and/or not implemented

Unused routes:

  1. "lists" & "ontology" → HintComponent

    • get rid of routes to HintComponent
    • clean up HintComponent (remove unused "lists" and "ontology")
  2. "dashboard"

  • get rid of route
  • fix its "implementation" (user component & globals.usernav)

Unused and not implemented components which have a route:

  1. clean up SettingsComponent from Appglobal.projectNav
  • do NOT get rid of SettingsComponent
    • get rid of Appglobal.projectNav → only one menuItem used by the whole app and this is in the very SettingsComponent. This should should therefore be defined locally in the Settingscomponent
    • get rid of Appglobal.projectNav and "this.navigation" in ProjectComponent hence not used at all
  1. Remove PermissionComponent and AddGroupComponent

The PermissionComponent and its child AddGroupComponent are not yet implemented and not routed anywhere except the Permissionscomponent itself by the exact Url via routing.module

  1. Clean up UserComponent and implement route constants

  2. Remove unused CollectionListComponent

    The component is not routed, not used and not implemented

  3. Remove GroupsComponent and it child GroupsListComponent
    Both components are not yet implemented, not routed and not used in any template

@domsteinbach domsteinbach marked this pull request as ready for review October 24, 2023 14:25
@domsteinbach domsteinbach merged commit 2ce9065 into main Oct 24, 2023
13 checks passed
@domsteinbach domsteinbach deleted the feature/dev-2835-cleanup-routes-and-unused-components branch October 24, 2023 14:50
irmastnt added a commit that referenced this pull request Oct 24, 2023
…return-true-observables-that-also

* main:
  refactor: cleanup routes and unused components (#1239)

# Conflicts:
#	apps/dsp-app/src/app/project/permission/permission.component.html
#	apps/dsp-app/src/app/project/permission/permission.component.ts
#	apps/dsp-app/src/app/project/project.component.ts
#	apps/dsp-app/src/app/user/user.component.html
#	apps/dsp-app/src/app/user/user.component.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants