refactor(date picker): implement date picker as standalone component #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove AppDatePickerModule
DEV-2688 Refactor datepicker to standalone component
Refactor the datepicker component in the shared lib (https://github.com/dasch-swiss/dsp-das/blob/ab847bd06f9a5eeb5531a8279e370b3e9a109cb1/libs/vre/shared/app-date-picker/src/lib/app-date-picker/app-date-picker.component.ts) to a standalone component.
|
mdelez
approved these changes
Oct 31, 2023
| @@ -29,7 +28,6 @@ import { PropertyFormItem } from '../../../data-access/advanced-search-store/adv | |||
| MatSelectModule, | |||
| FormsModule, | |||
| ReactiveFormsModule, | |||
| AppDatePickerModule, | |||
There was a problem hiding this comment.
Please add the import for the AppDatePickerComponent here
domsteinbach
deleted the
feature/dev-2688-refactor-datepicker-to-standalone-component
branch
irmastnt
added a commit
that referenced
this pull request
Oct 31, 2023
…return-true-observables-that-also * main: refactor(date picker): implement date picker as standalone component (#1251) fix(app/help): fix links to releases (#1253) fix(app/resource): removed developer feature that created annotation bug (#1254) feat(expert search): implement default gravsearch as placeholder (#1247) feat(project description): order project descriptions by language (#1250) # Conflicts: # apps/dsp-app/src/app/project/description/description.component.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves DEV-2688