Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type errors): fix type errors #1255

Merged
merged 1 commit into from Nov 1, 2023
Merged

fix(type errors): fix type errors #1255

merged 1 commit into from Nov 1, 2023

Conversation

domsteinbach
Copy link
Contributor

resolves DEV-2895

@linear Linear
Copy link

linear bot commented Oct 31, 2023

DEV-2895 TypeErrors datadog logging

Fix type errors reported to datadog log.

@domsteinbach domsteinbach marked this pull request as ready for review October 31, 2023 15:24
irmastnt
irmastnt approved these changes Oct 31, 2023
View reviewed changes
apps/dsp-app/src/app/workspace/results/list-view/list-view.component.html
@@ -1,5 +1,5 @@
<!-- header / toolbar to select view and pagination -->
<div *ngIf="!loading && (numberOfAllResults > 0 && resources.resources.length)" class="list-view-header">
<div *ngIf="!loading && (numberOfAllResults > 0 && resources?.resources?.length)" class="list-view-header">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably resources?.resources?.length > 0 should be here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my work and I did not look at the logic and did not want to change anything but get rid of the spawning type error. But yes, I think it should probably be !!resources.resources.length or resources.resources.length > 0. The whole component needs major refactoring as I look at it ...

@domsteinbach domsteinbach merged commit 389eccb into main Nov 1, 2023
13 checks passed
@domsteinbach domsteinbach deleted the feature/dev-2895-fix-typeerrors-datadog-logging branch November 1, 2023 06:47
@daschbot daschbot mentioned this pull request Nov 1, 2023
Merged
irmastnt added a commit that referenced this pull request Nov 1, 2023
@irmastnt
Merge branch 'main' into feature/dev-2490-refactor-sessionservice-to-…
c4f8554 
…return-true-observables-that-also

* main:
  feat(list-value): make list menu resemble a dropdrown (#1256)
  fix(type errors): fix type errors (#1255)

# Conflicts:
#	apps/dsp-app/src/app/workspace/results/list-view/list-view.component.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irmastnt irmastnt irmastnt approved these changes

@mdelez mdelez Awaiting requested review from mdelez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@domsteinbach @irmastnt