Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date-picker): date-picker doesn't show in advanced search #1267

Conversation

mdelez
Copy link
Collaborator

@mdelez mdelez commented Nov 16, 2023

resolves DEV-2965

@mdelez mdelez added the bug A bug fix label Nov 16, 2023
@mdelez mdelez self-assigned this Nov 16, 2023
Copy link

linear bot commented Nov 16, 2023

DEV-2965 If using a date value with the comparison operators "equals" and "does not equal" defining the date not possible (missing field) in Advanced Search

Bug report from Barbara Schingnitz (webern):

"If I go to "Chronology" or "Correspondence" in the resource class and then add "Date" as a property and then select "equals" (or all other modifications that are not just "exists" or "does not exist") - then, as before, something should open where I can then define the date in some form - year, month, day? So far, there was a calendar, so to speak, where I could then also make a period if necessary or only fix a single date?

I no longer see that.

For all other properties that I can modify in any way, it works as far as I can see: I select my comparison operator and another line pops up so that I can further define my choice."

Steps to reproduce:

  1. Go to project "Anton Webern Gesamtausgabe" on prod
  2. Click on Advanced Search
  3. Select "Chronology" for a resource class
  4. Select "Date" as a property
  5. Select "does not equal" as a comparison operator
  6. There is no input field to define the date

Expected behavior:

I would expect that if I choose a date with the comparison operator, I can define the date in a form/input field.

Screenshot 2023-11-16 at 12.28.34.png

Release Version: 2023.11.02

https://app.dasch.swiss/project/ot7I2nU-SdeXIf17LX_h3g/advanced-search

@mdelez mdelez marked this pull request as ready for review November 16, 2023 12:53
@mdelez mdelez requested a review from irmastnt November 16, 2023 13:04
@irmastnt irmastnt merged commit 3d2778f into main Nov 16, 2023
13 checks passed
@irmastnt irmastnt deleted the feature/dev-2965-if-using-a-date-value-with-the-comparison-operators-equals branch November 16, 2023 13:08
irmastnt added a commit that referenced this pull request Nov 16, 2023
…return-true-observables-that-also

* main:
  chore(main): release 11.1.3 (#1268)
  fix(date-picker): date-picker doesn't show in advanced search (#1267)
  chore(main): release 11.1.2 (#1265)
  fix(results): go back to search form button fix (#1266)
  fix(advanced-search): undefined error leads to blank page (#1264)
  chore(main): release 11.1.1 (#1263)
  fix(results): user unable to execute second fulltext search (#1262)
  fix(activate/deactivate project): subscribe to the observable (#1261)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants