Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dsp-app): Resolves DEV-2687 #1336

Merged
merged 8 commits into from Jan 11, 2024
Merged

fix(dsp-app): Resolves DEV-2687 #1336

merged 8 commits into from Jan 11, 2024

Conversation

irmastnt
Copy link
Contributor

@irmastnt irmastnt commented Jan 9, 2024 •
edited

fix(dsp-app): Resolves DEV-2687
enhancement: navigates to existing page after login, navigates home after logout.
refactor: authentication guard and service

@irmastnt
fix: authentication refactoring, isSessionValid is used instead of Be…
172a160 
…haviourSubject, navigates to existing page after login, navigates home after logout. Fixed auth.guard.
@irmastnt
Merge branch 'main' into feature/dev-2687-contradicting-login-state-m…
39f71da 
…essage

* main:
  refactor: add confirm dialog service (#1335)
  fix: add icon to common input (#1333)
  fix: geoname property lookup (#1334)

# Conflicts:
#	apps/dsp-app/src/app/main/action/login-form/login-form.component.ts
@linear Linear
Copy link

linear bot commented Jan 9, 2024

DEV-2687 Contradicting login state & message

@irmastnt irmastnt changed the title Feature/dev 2687 contradicting login state message fix(dsp-app): Resolves DEV-2687 enhancement: navigates to existing page after login, navigates home after logout. refactor: authentication guard and service Jan 9, 2024
@irmastnt irmastnt changed the title fix(dsp-app): Resolves DEV-2687 enhancement: navigates to existing page after login, navigates home after logout. refactor: authentication guard and service fix(dsp-app): Resolves DEV-2687 Jan 9, 2024
@irmastnt irmastnt merged commit d6211f9 into main Jan 11, 2024
13 checks passed
@irmastnt irmastnt deleted the feature/dev-2687-contradicting-login-state-message branch January 11, 2024 12:47
@daschbot daschbot mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derschnee68 derschnee68 derschnee68 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@irmastnt @derschnee68