fix(still image): User without permission can draw a region #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er without permission
derschnee68
requested changes
Jan 23, 2024
| @@ -23,6 +23,7 @@ | |||
| [currentTab]="selectedTabLabel" | |||
| [parentResource]="incomingResource ? incomingResource.res : resource.res" | |||
| [activateRegion]="selectedRegion" | |||
| [adminPermissions]="isAdmin$ | async" | |||
There was a problem hiding this comment.
You don't need to add an input adminPermission if you use the admin selector. You can add it straight to the component ?
There was a problem hiding this comment.
There is no equivalent selector yet as far as I can see (it is not sysadmin, it is sysadmin or project admin/member of the current project). So I went for a short streamlined fix reusing what is already there instead of refactoring and implementing new stuff as well.
…on-but-not-save-it
derschnee68
approved these changes
Jan 24, 2024
…on-but-not-save-it
domsteinbach
deleted the
feature/dev-3200-unknown-user-can-add-a-region-but-not-save-it
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and press the replace image button
resolves DEV-3200