Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Send X-Asset-Ingested header for update/create of value and resources (DEV-2628) #639

Merged
merged 2 commits into from
May 23, 2024
Merged

feat!: Send X-Asset-Ingested header for update/create of value and resources (DEV-2628) #639

merged 2 commits into from
May 23, 2024

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented May 21, 2024 •
edited
Loading

This represents a breaking change in the sense that when using the dsp-js-lib the asset upload must be done using dsp-ingest and cannot be done using Sipi anymore.

@seakayone seakayone changed the title feat: Send X-Asset-Ingested header for update value and create resource feat: Send X-Asset-Ingested header for update value and create resource (DEV-2628) May 21, 2024
@seakayone seakayone self-assigned this May 21, 2024
@seakayone seakayone force-pushed the feat/send-x-asset-ingested-always branch from 076bcfc to 9f32f01 Compare May 22, 2024 14:11
@seakayone seakayone force-pushed the feat/send-x-asset-ingested-always branch from 9f32f01 to 2ba1008 Compare May 22, 2024 14:23
@seakayone seakayone changed the title feat: Send X-Asset-Ingested header for update value and create resource (DEV-2628) feat: Send X-Asset-Ingested header for update/create of value and resources (DEV-2628) May 22, 2024
BalduinLandolt
BalduinLandolt approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable, but I do not know JS-LIB at all, so I wouldn't know if the present changes are sufficient

irmastnt
irmastnt approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@irmastnt irmastnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me, just, as a side note using constants would be beneficial in order to decrease repetitive code.

@seakayone seakayone changed the title feat: Send X-Asset-Ingested header for update/create of value and resources (DEV-2628) feat!: Send X-Asset-Ingested header for update/create of value and resources (DEV-2628) May 23, 2024
@seakayone seakayone mentioned this pull request May 23, 2024
Merged
@seakayone
Copy link
Contributor Author

seakayone commented May 23, 2024 •
edited
Loading

Ok for me, just, as a side note using constants would be beneficial in order to decrease repetitive code.

Good point. I would prefer that as well. Unfortunately I have not been able to add it to the Constants.ts, import and use it as the key for the headerOpts object. Keeps complaining that the string is not a RecursiveString something.

Next time maybe?

@seakayone seakayone merged commit be1d2c5 into main May 23, 2024
13 checks passed
@seakayone seakayone deleted the feat/send-x-asset-ingested-always branch May 23, 2024 13:19
@daschbot daschbot mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irmastnt irmastnt irmastnt approved these changes

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@derschnee68 derschnee68 Awaiting requested review from derschnee68

@domsteinbach domsteinbach Awaiting requested review from domsteinbach

Assignees

@seakayone seakayone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seakayone @irmastnt @BalduinLandolt