Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use single quotes around passwords to prevent problems with special characters (DEV-1825) #320

Merged
merged 1 commit into from Mar 9, 2023
Merged

docs: use single quotes around passwords to prevent problems with special characters (DEV-1825) #320

merged 1 commit into from Mar 9, 2023

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-1825

@jnussbaum jnussbaum self-assigned this Mar 9, 2023
@linear
Copy link

linear bot commented Mar 9, 2023

DEV-1825 DSP-TOOLS: docs: use '' around passwords in CLI commands

BalduinLandolt
BalduinLandolt approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you ensured that argparse is smart enough to strip those away, so that they don't get included?

@jnussbaum
Copy link
Collaborator Author

I assume you ensured that argparse is smart enough to strip those away, so that they don't get included?

Yes. Since a long time, I always have to use single quotes around my passwords, because they contain special characters.

@jnussbaum jnussbaum changed the title docs: use single quotes around passwords in the CLI commands (DEV-1825) docs: use single quotes around passwords to prevent problems with special characters (DEV-1825) Mar 9, 2023
@jnussbaum jnussbaum merged commit ca2bf1a into main Mar 9, 2023
3 checks passed
@jnussbaum jnussbaum deleted the wip/dev-1825-passwords-in-cli branch March 9, 2023 08:35
@daschbot daschbot mentioned this pull request Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@irinaschubert irinaschubert Awaiting requested review from irinaschubert

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnussbaum @BalduinLandolt