Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create, get): handle comment to ontology (DEV-1852) #326

Merged
merged 2 commits into from Mar 14, 2023

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-1852

@jnussbaum jnussbaum self-assigned this Mar 13, 2023
@linear
Copy link

linear bot commented Mar 13, 2023

DEV-1852 DSP-TOOLS: comment to ontology behaves buggy

State as is

The get command writes the comment of an ontology into the field "comment", which is correct but undocumented.

The create command ignores the comment entirely.

The schema file disallows the "comment" field, but allows a "comments" object with multi-language support, which is not possible to have on a DSP server.

State to be

The get command can stay as it is, except that the fields of the ontology object should be reordered (move "comment" further up)

The create command should learn to use the "comment" field.

The schema should allow "comment" as single string but disallow "comments" as multi-language object

@jnussbaum jnussbaum merged commit 5af3f19 into main Mar 14, 2023
2 checks passed
@jnussbaum jnussbaum deleted the wip/dev-1852-comment-of-ontology branch March 14, 2023 08:16
@daschbot daschbot mentioned this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants