Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: minor improvements (DEV-1912) #336

Merged
merged 1 commit into from Mar 17, 2023
Merged

refactor: minor improvements (DEV-1912) #336

merged 1 commit into from Mar 17, 2023

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-1912

@jnussbaum jnussbaum self-assigned this Mar 17, 2023
@linear
Copy link

linear bot commented Mar 17, 2023

DEV-1912 DSP-TOOLS: bug in xmlupload

The method _write_id2iri_mapping_and_metrics() cannot handle the type Path for its parameter input_file .

in the same shot, optimize _parse_xml_file()

@jnussbaum jnussbaum merged commit 91664a9 into main Mar 17, 2023
2 checks passed
@jnussbaum jnussbaum deleted the wip/dev-1912-minor-improvements branch March 17, 2023 11:18
@daschbot daschbot mentioned this pull request Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jnussbaum