Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xmlupload): legitimate html-escapes in utf8-texts don't raise a validation error any more (DEV-1936) #341

Merged
merged 4 commits into from Mar 21, 2023
Merged

fix(xmlupload): legitimate html-escapes in utf8-texts don't raise a validation error any more (DEV-1936) #341

merged 4 commits into from Mar 21, 2023

Conversation

jnussbaum
Copy link
Collaborator

resolves DEV-1936

@jnussbaum jnussbaum self-assigned this Mar 20, 2023
@linear
Copy link

linear bot commented Mar 20, 2023

DEV-1936 DSP-TOOLS: utf8-tags: HTML-escapes erroneously interpreted as tags

The XML <text encoding="utf8">(&lt;2cm) (&gt;10cm)</text> is parsed as (<2cm) (>10cm) by lxml, which causes a validation error, because utf8-tags must not contain tags.

@jnussbaum jnussbaum changed the title fix: HTML-escapes in utf8-texts are not any more parsed as tags (DEV-1936) fix: prevent html-escapes in utf8-texts from being parsed as tags (DEV-1936) Mar 21, 2023
@jnussbaum jnussbaum changed the title fix: prevent html-escapes in utf8-texts from being parsed as tags (DEV-1936) fix(xmlupload): legitimate html-escapes in utf8-texts don't raise a validation error any more (DEV-1936) Mar 21, 2023
BalduinLandolt
BalduinLandolt approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnussbaum jnussbaum merged commit cf90269 into main Mar 21, 2023
2 checks passed
@jnussbaum jnussbaum deleted the wip/dev-1936-utf8-escapes-interpreted-as-tags branch March 21, 2023 13:24
@daschbot daschbot mentioned this pull request Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnussbaum @BalduinLandolt