Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to Python 3.11 (DEV-2524) #461

Merged
merged 1 commit into from Aug 9, 2023
Merged

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

@jnussbaum jnussbaum self-assigned this Aug 9, 2023
@linear
Copy link

linear bot commented Aug 9, 2023

DEV-2524 move to python 3.11

Currently, DSP-TOOLS relies on Python >= 3.9. This has some disadvantages:

  • The tests on GitHub CI run with Python 3.9, which is slower than 3.11, and produces less comprehensible error messages.
  • The codebase of DSP-TOOLS cannot take advantage of newer syntax introduced in 3.10 / 3.11.

In the RDU team, we agreed that we can move to 3.11. We just have to inform Lausanne some days before the release, so that they know that they must have Python 3.11 on their machines.

The schedule to migrate DSP-TOOLS to Python 3.11 is as follows:

  1. specify 3.11 in pyproject.toml and on https://pypi.org, so that the users with an older Python version cannot update DSP-TOOLS any more, and must install Python 3.11 first.
  2. If step 1 works without problems, use new features

Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Now too long if-elif listings can be replaced with pattern matching :)

@jnussbaum jnussbaum merged commit 74a93e5 into main Aug 9, 2023
4 checks passed
@jnussbaum jnussbaum deleted the wip/dev-2524-python-3.11 branch August 9, 2023 15:08
@daschbot daschbot mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants