Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pandas deprecates inplace parameter (DEV-2618) #511

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@linear
Copy link

linear bot commented Sep 8, 2023

DEV-2618 refactor: pandas deprecates inplace parameter

It is likely that pandas will deprecate the inplace parameter in future versions. Replace all the existing.

@Nora-Olivia-Ammann Nora-Olivia-Ammann changed the title refactor: pandas deprecates inplace parameter (Dev-2618) refactor: pandas deprecates inplace parameter (DEV-2618) Sep 8, 2023
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add yourself as Assignee? Apart from that, the PR is good, although I cannot explain why test__rename_deprecated_lang_cols() succeeded before.

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Sep 11, 2023
@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit 8d6d3f7 into main Sep 11, 2023
4 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the refactor-pandas-deprecates-inplace-parameter-(Dev-2618) branch September 11, 2023 14:21
@daschbot daschbot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants