chore: fix gui_attributes notation (DEV-2651) #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-2651 change = to : in documentation example
gui_attributes in the documentation show a = but in the excel we expect a : https://docs.dasch.swiss/2023.09.01/DSP-TOOLS/file-formats/json-project/ontologies/#decimalvalue |
jnussbaum
changed the title
jnussbaum
reviewed
Sep 12, 2023
| @@ -479,7 +479,7 @@ See the [xmlupload documentation](../xml-data-file.md#list-prop) for more inform | |||
|
|
|||
| - `List`: A GUI element for *ListValue*. A dropdown to select a list node. | |||
| - *gui_attributes*: | |||
| - `hlist=<list-name>` (required): | |||
| - `hlist:<list-name>` (required): | |||
There was a problem hiding this comment.
Here we have the <> to indicate that "list-name" is a placeholder, and not the literal string "list-name". Would it perhaps help to do this everywhere consistently?
Like this:
- `maxlength: <integer>` (optional): maximal length (number of characters accepted)
jnussbaum
reviewed
Sep 12, 2023
| @@ -479,7 +479,7 @@ See the [xmlupload documentation](../xml-data-file.md#list-prop) for more inform | |||
|
|
|||
| - `List`: A GUI element for *ListValue*. A dropdown to select a list node. | |||
| - *gui_attributes*: | |||
| - `hlist=<list-name>` (required): | |||
| - `hlist:<list-name>` (required): | |||
There was a problem hiding this comment.
And I would then also add a whitespace everywhere:
Suggested change
| - `hlist:<list-name>` (required): | |
| - `hlist: <list-name>` (required): |
jnussbaum
approved these changes
Sep 12, 2023
Nora-Olivia-Ammann
deleted the
wip/chore-clear-up-gui_attribues-notation-(DEV-2651)
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.