fix(excel2json): don't crash if optional columns are deleted in "properties" Excel file (DEV-2652) #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-2652 excel columns optional
should support deleted excel columns whose content is optional src/dsp_tools/utils/excel2json/properties.py |
jnussbaum
reviewed
Sep 14, 2023
jnussbaum
reviewed
Sep 14, 2023
jnussbaum
reviewed
Sep 14, 2023
jnussbaum
reviewed
Sep 14, 2023
jnussbaum
reviewed
Sep 14, 2023
jnussbaum
reviewed
Sep 14, 2023
|
@Nora-Olivia-Ammann This PR is okay now, but could you improve the title + text of the linear ticket? As it is now, I only understand it because I know the context. But imagine we discuss it in the DSP-TOOLS meeting: no one would understand. BTW: The same applies for some other tickets you created. If you have time, could you reformulate them? |
Nora-Olivia-Ammann
changed the title
|
@Nora-Olivia-Ammann : IMHO, the title is not expressive enough. What do you think about "fix(excel2json): don't crash if optional columns are deleted in "properties" Excel file" --> and the linear ticket accordingly |
Nora-Olivia-Ammann
changed the title
jnussbaum
approved these changes
Sep 15, 2023
Nora-Olivia-Ammann
deleted the
fix-excel-columns-optional-(DEV-2652)
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.