New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(xmlupload): _upload_stashed_xml_texts (DEV-2710) #532
Merged
Nora-Olivia-Ammann
merged 32 commits into
main
from
wip/dev-2710-refactor-_upload_stashed_xml_texts
Sep 28, 2023
Merged
refactor(xmlupload): _upload_stashed_xml_texts (DEV-2710) #532
Nora-Olivia-Ammann
merged 32 commits into
main
from
wip/dev-2710-refactor-_upload_stashed_xml_texts
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-2710 refactor _upload_stashed_xml_texts
Diagnostics showed, that if the stashed links are large enough, there is a significant gap between one update of a stashed XML text till the next. The problem does not lie with the dsp-api, but with the Python code. In order to diagnose what aspect of the stash causes the delay, the function "_upload_stashed_xml_texts" in xml_upload.py will be refactored. After that, the analysis will be run again. |
Nora-Olivia-Ammann
changed the title
refactor(xmlupload.py): _upload_stashed_xml_texts (DEV-2710)
refactor(xmlupload): _upload_stashed_xml_texts (DEV-2710)
Sep 28, 2023
jnussbaum
reviewed
Sep 28, 2023
jnussbaum
reviewed
Sep 28, 2023
jnussbaum
reviewed
Sep 28, 2023
jnussbaum
reviewed
Sep 28, 2023
Co-authored-by: Johannes Nussbaum <39048939+jnussbaum@users.noreply.github.com>
jnussbaum
reviewed
Sep 28, 2023
…ps://github.com/dasch-swiss/dsp-tools into wip/dev-2710-refactor-_upload_stashed_xml_texts
jnussbaum
reviewed
Sep 28, 2023
jnussbaum
reviewed
Sep 28, 2023
Co-authored-by: Johannes Nussbaum <39048939+jnussbaum@users.noreply.github.com>
Co-authored-by: Johannes Nussbaum <39048939+jnussbaum@users.noreply.github.com>
Co-authored-by: Johannes Nussbaum <39048939+jnussbaum@users.noreply.github.com>
Co-authored-by: Johannes Nussbaum <39048939+jnussbaum@users.noreply.github.com>
jnussbaum
reviewed
Sep 28, 2023
jnussbaum
reviewed
Sep 28, 2023
…ps://github.com/dasch-swiss/dsp-tools into wip/dev-2710-refactor-_upload_stashed_xml_texts
jnussbaum
approved these changes
Sep 28, 2023
Nora-Olivia-Ammann
deleted the
wip/dev-2710-refactor-_upload_stashed_xml_texts
branch
September 28, 2023 12:25
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.