Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(xmlupload): file upload_stashed_resptr_props.py (DEV-2774) #542

Merged
merged 9 commits into from Oct 5, 2023
Merged

refactor(xmlupload): file upload_stashed_resptr_props.py (DEV-2774) #542

merged 9 commits into from Oct 5, 2023

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@linear
Copy link

linear bot commented Oct 4, 2023

DEV-2761 refactor xmlupload into individual functions

the functions are rather larger and will be divided into smaller functions

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Oct 4, 2023
@Nora-Olivia-Ammann Nora-Olivia-Ammann changed the title refactor(xmlupload): file upload_stashed_resptr_props.py (DEV-2761) refactor(xmlupload): file upload_stashed_resptr_props.py (DEV-2774) Oct 4, 2023
@linear
Copy link

linear bot commented Oct 4, 2023

DEV-2774 refactor file: upload_stashed_resptr_props.py

jnussbaum
jnussbaum requested changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from some formal remarks, I'm happy with this PR.

BalduinLandolt
BalduinLandolt approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to merge

src/dsp_tools/utils/xmlupload/upload_stashed_resptr_props.py Outdated Show resolved Hide resolved
jnussbaum
jnussbaum approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I blocked you, here is now my approval. In the future I will proceed as Balduin suggested in the chat.

@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit 422bbb3 into main Oct 5, 2023
4 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/dev-2761-refactor-xmlupload-stashed-resptr-porps branch October 5, 2023 08:46
@daschbot daschbot mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@jnussbaum jnussbaum jnussbaum approved these changes

Assignees

@Nora-Olivia-Ammann Nora-Olivia-Ammann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nora-Olivia-Ammann @BalduinLandolt @jnussbaum