refactor(xmlupload): file xmlupload.py (DEV-2775) #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nora-Olivia-Ammann
changed the title
….com/dasch-swiss/dsp-tools into wip/dev-2775-refactor-file-xmlupload
|
The file is again rather large. I would suggest, to move out all the sipi stuff. This way it will also be easier to change if we move to ingest. What do you think? |
BalduinLandolt
approved these changes
Oct 5, 2023
Feel free, it will certainly be good. But I would say we should eventually look at package structure in a broader way, which might make some changes of that nature obsolete. |
Co-authored-by: Balduin Landolt <33053745+BalduinLandolt@users.noreply.github.com>
….com/dasch-swiss/dsp-tools into wip/dev-2775-refactor-file-xmlupload
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.