Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: create specific objects for stash information (DEV-2787) #557

Merged
merged 30 commits into from Oct 12, 2023
Merged

refactor: create specific objects for stash information (DEV-2787) #557

merged 30 commits into from Oct 12, 2023

Conversation

BalduinLandolt
Copy link
Collaborator

No description provided.

@linear
Copy link

linear bot commented Oct 6, 2023

DEV-2787 draft stash datastructure

@BalduinLandolt BalduinLandolt self-assigned this Oct 6, 2023
@BalduinLandolt BalduinLandolt marked this pull request as ready for review October 12, 2023 09:20
jnussbaum
jnussbaum approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really difficult to review. If there was a bug in this PR, I wouldn't find it 🙈 . Is there a way to write tests?

@BalduinLandolt
Copy link
Collaborator Author

Really difficult to review. If there was a bug in this PR, I wouldn't find it 🙈 . Is there a way to write tests?

I know, this turned out more complicated than I hoped. But I'm actually rather confident, there were some bugs in it, and all of them were caught by the e2e tests, so I think it should be ok.
I'm working towards making things more testable, but I'm not yet there; and I don't want to write bad tests just for the sake of it.

@jnussbaum
Copy link
Collaborator

Really difficult to review. If there was a bug in this PR, I wouldn't find it 🙈 . Is there a way to write tests?

I know, this turned out more complicated than I hoped. But I'm actually rather confident, there were some bugs in it, and all of them were caught by the e2e tests, so I think it should be ok. I'm working towards making things more testable, but I'm not yet there; and I don't want to write bad tests just for the sake of it.

Good to hear, that sounds good.

Nora-Olivia-Ammann
Nora-Olivia-Ammann approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@Nora-Olivia-Ammann Nora-Olivia-Ammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but would it be possible to add the permissions?

src/dsp_tools/utils/xmlupload/stash/stash_models.py Show resolved Hide resolved
src/dsp_tools/utils/xmlupload/upload_stashed_resptr_props.py Show resolved Hide resolved
@BalduinLandolt BalduinLandolt enabled auto-merge (squash) October 12, 2023 12:33
@BalduinLandolt BalduinLandolt merged commit b38c2d3 into main Oct 12, 2023
8 checks passed
@BalduinLandolt BalduinLandolt deleted the feature/dev-2787-draft-stash-datastructure branch October 12, 2023 12:38
@daschbot daschbot mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnussbaum jnussbaum jnussbaum approved these changes

@Nora-Olivia-Ammann Nora-Olivia-Ammann Nora-Olivia-Ammann approved these changes

Assignees

@BalduinLandolt BalduinLandolt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BalduinLandolt @jnussbaum @Nora-Olivia-Ammann