Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: identify temporary text values with UUID instead of text hash (DEV-2790) #558

Conversation

BalduinLandolt
Copy link
Collaborator

No description provided.

@BalduinLandolt BalduinLandolt self-assigned this Oct 7, 2023
@linear
Copy link

linear bot commented Oct 7, 2023

@BalduinLandolt BalduinLandolt marked this pull request as ready for review October 7, 2023 13:04
@BalduinLandolt
Copy link
Collaborator Author

There are two questions open in this PR, both marked with TODO:

  1. I'm unsure if I'm missing some purge logic
  2. I commented out one test because it could not be left as it was, but I also don't want to adopt it to the changed code before we talk about how tests should look like.

Apart from that, the PR is ready, I think.

@BalduinLandolt BalduinLandolt enabled auto-merge (squash) October 9, 2023 13:10
@BalduinLandolt BalduinLandolt merged commit 08624b2 into main Oct 9, 2023
7 checks passed
@BalduinLandolt BalduinLandolt deleted the feature/dev-2790-use-ids-instead-of-text-hashes-for-text-values branch October 9, 2023 13:17
@daschbot daschbot mentioned this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants