New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: modularize xmlupload (DEV-2813) #568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at it in extreme detail but it looks good to me. Please tell me if you would like a closer inspection.
I'm pretty confident that I haven't broken anything (says he, right after breaking something and having to fix it...). The most important thing to me would be to know if the steps that are now being done in the big |
I will play it trough in the code this afternoon. |
I'll merge it as it is for now, but we can still improve on it, if there is something you don't like. Just let me know! |
No description provided.