Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: introduce abstraction layer for connection (DEV-2820) #570

Merged
merged 10 commits into from Oct 17, 2023
Merged

refactor: introduce abstraction layer for connection (DEV-2820) #570

merged 10 commits into from Oct 17, 2023

Conversation

BalduinLandolt
Copy link
Collaborator

No description provided.

@BalduinLandolt BalduinLandolt self-assigned this Oct 14, 2023
@linear
Copy link

linear bot commented Oct 14, 2023

DEV-2820 Hide connection behind interface

@BalduinLandolt BalduinLandolt marked this pull request as ready for review October 16, 2023 14:37
jnussbaum
jnussbaum approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks from my side, but it looks good.

src/dsp_tools/connection/__init__.py Outdated Show resolved Hide resolved
src/dsp_tools/utils/xmlupload/xmlupload.py Outdated Show resolved Hide resolved
test/e2e/test_group.py Outdated Show resolved Hide resolved
test/e2e/test_listnode.py Show resolved Hide resolved
@BalduinLandolt BalduinLandolt enabled auto-merge (squash) October 17, 2023 09:34
@BalduinLandolt BalduinLandolt merged commit 87c1e18 into main Oct 17, 2023
8 checks passed
@BalduinLandolt BalduinLandolt deleted the feature/dev-2820-hide-connection-behind-interface branch October 17, 2023 12:00
@daschbot daschbot mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnussbaum jnussbaum jnussbaum approved these changes

@Nora-Olivia-Ammann Nora-Olivia-Ammann Nora-Olivia-Ammann approved these changes

Assignees

@BalduinLandolt BalduinLandolt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BalduinLandolt @jnussbaum @Nora-Olivia-Ammann