Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: create JSON-LD context without API request (DEV-2845) #581

Merged
merged 5 commits into from Oct 19, 2023
Merged

refactor: create JSON-LD context without API request (DEV-2845) #581

merged 5 commits into from Oct 19, 2023

Conversation

BalduinLandolt
Copy link
Collaborator

No description provided.

@linear
Copy link

linear bot commented Oct 18, 2023

DEV-2845 Create `@conext` without GET request

dsp-tools/src/dsp_tools/utils/xmlupload/upload_stashed_resptr_props.py

Line 45 in 6d9f082

existing_resource = try_network_action(con.get, route=f"/v2/resources/{quote_plus(res_iri)}")
is only needed for getting the context, which should not be necessary.

If we get rid of this, resptr props should also get "cheaper" to stash as opposed to text values, because those will keep requiring this call.

@BalduinLandolt BalduinLandolt self-assigned this Oct 18, 2023
jnussbaum
jnussbaum approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

Nora-Olivia-Ammann
Nora-Olivia-Ammann approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@Nora-Olivia-Ammann Nora-Olivia-Ammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also happy, because it will unlikely to be a problem in the future. But we should not forget about the limitations for the future.

@BalduinLandolt BalduinLandolt merged commit dcc655d into main Oct 19, 2023
8 checks passed
@BalduinLandolt BalduinLandolt deleted the feature/dev-2845-create-conext-without-get-request branch October 19, 2023 07:58
@daschbot daschbot mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnussbaum jnussbaum jnussbaum approved these changes

@Nora-Olivia-Ammann Nora-Olivia-Ammann Nora-Olivia-Ammann approved these changes

Assignees

@BalduinLandolt BalduinLandolt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BalduinLandolt @jnussbaum @Nora-Olivia-Ammann